potiuk commented on code in PR #30975:
URL: https://github.com/apache/airflow/pull/30975#discussion_r1181271716
##########
airflow/providers/sqlite/operators/sqlite.py:
##########
@@ -49,6 +50,6 @@ def __init__(self, *, sqlite_conn_id: str = "sqlite_default",
**kwargs) -> None:
warnings.warn(
"""This class is deprecated.
Please use
`airflow.providers.common.sql.operators.sql.SQLExecuteQueryOperator`.""",
- DeprecationWarning,
+ AirflowProviderDeprecationWarning,
Review Comment:
Theorethically we could add dependency on airflow for pip (we used to have
them) but it breaks tools that detect it as cycles, what we could do is that we
could do similar thing as some other packages do - check it at runtime when it
is used and raise a warning or error. This way if someone install a new version
of sqlite on old airflow version it would refuse to start.
It won't prevent it from being upgraded, but at least we can raise a clear
error message in this case and ask the user to upgrade airflow if they want to
update the provider to a newer version.
I think we should do it anyway for all preinstalled packages - WDYT @eladkal
?
##########
airflow/providers/sqlite/operators/sqlite.py:
##########
@@ -49,6 +50,6 @@ def __init__(self, *, sqlite_conn_id: str = "sqlite_default",
**kwargs) -> None:
warnings.warn(
"""This class is deprecated.
Please use
`airflow.providers.common.sql.operators.sql.SQLExecuteQueryOperator`.""",
- DeprecationWarning,
+ AirflowProviderDeprecationWarning,
Review Comment:
Theorethically we could add dependency on airflow for pip (we used to have
them) but it breaks tools that detect it as cycles, what we could do is that we
could do similar thing as some other packages do - check it at runtime when it
is used and raise a warning or error. This way if someone installs a new
version of sqlite on old airflow version it would refuse to start.
It won't prevent it from being upgraded, but at least we can raise a clear
error message in this case and ask the user to upgrade airflow if they want to
update the provider to a newer version.
I think we should do it anyway for all preinstalled packages - WDYT @eladkal
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]