jonshea commented on PR #30923:
URL: https://github.com/apache/airflow/pull/30923#issuecomment-1529315138

   I believe have fixed the CI failures on static-checks and build-docs.
   
   I am slightly anxious about this change. In some sense, it is a breaking API 
change (at least at the type checking level), and it may result in type 
checking failures to airflow users when they upgrade, which is annoying for 
users to need to manage.
   
   But on the other hand, the types are currently wrong, and users who rely on 
them may have runtime errors. That is how I found this issue. And in 
particular, `get_wildcard_key` was typed as returning just `S3Transfer` when it 
very clearly can return `None` (as well as returning `S3.Object` rather than 
`S3Transfer`).
   
   I am not sure if Airflow has a policy on this kind of change. Personally, I 
would like the correct types. But if you want something different (or to close 
the PR without merging), I am happy to oblige.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to