zachliu commented on issue #31059: URL: https://github.com/apache/airflow/issues/31059#issuecomment-1535053247
i closed https://github.com/apache/airflow/issues/30997 because although the line https://github.com/apache/airflow/blob/ab54c63940a99646df974d4bcf2e37415e277e69/airflow/utils/log/file_task_handler.py#L323 is hard to read, it does fulfill the expected logic cases as i mentioned https://github.com/apache/airflow/issues/30997#issuecomment-1530767179 |case# | remote_logs | task state | triple not logic final output | |-----|-----------------|------------|-------------------------------| | 1 |no remote logs | unfinished | True (read local) | | 2 |got remote logs | finished | False (don't read local) | | 3 |no remote logs | finished | True (read local) | | 4 |got remote logs | unfinished | True (read local) | i didn't know case 2 was causing issues for other people :thinking: in my use case, i only care about case 1,3,4 (i do have remote logging as permanent records but i have my own `log_config.LOGGING_CONFIG` to force remote logs to be empty so that airflow always go to case 1,3,4 because reading from local is much faster) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
