potiuk commented on code in PR #30911:
URL: https://github.com/apache/airflow/pull/30911#discussion_r1186704387
##########
airflow/models/dag.py:
##########
@@ -2755,25 +2755,28 @@ def bulk_write_to_db(
session.add(orm_dag)
orm_dags.append(orm_dag)
- # Get the latest dag run for each existing dag as a single query
(avoid n+1 query)
- most_recent_subq = (
- session.query(DagRun.dag_id,
func.max(DagRun.execution_date).label("max_execution_date"))
- .filter(
- DagRun.dag_id.in_(existing_dags),
- or_(DagRun.run_type == DagRunType.BACKFILL_JOB,
DagRun.run_type == DagRunType.SCHEDULED),
+ most_recent_runs = {}
+ num_active_runs = {}
+ # Save runtime if dag is not scheduleable
+ if any([dag for dag in dags if not isinstance(dag.timetable,
NullTimetable)]):
Review Comment:
Actually I think it is not what I asked for, but likely this is even more
readable:
```suggestion
if not all([dag.isinstance(dag.timetable, NullTimetable) for dag in
dags]):
```
BTW. Can you also please add a unit test actually testing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
