potiuk commented on issue #75:
URL:
https://github.com/apache/airflow-client-python/issues/75#issuecomment-1537162974
> I don't think this is a mistake. DagRun Schema has dump_only dag_id (which
seems normal).
I am fine with that.
But I think that raises question - should we be adding an explanation about
it in release notes ?
the problem with this is that it is not some artifficial example :).
It did work before (I used that script in the past to test it, and well it
worked (I think the problem is that the new OpenAPI is more picky when it comes
to validating stuff and it allows to do stuff like this :) (which I understand
it should not be done):
```
dag_run = DAGRun(
dag_run_id='some_test_run',
dag_id=dag_id,
external_trigger=True,
)
```
And the thing is - the example comes from our repo:
https://github.com/apache/airflow-client-python/blob/main/dev/test_python_client.py
And this actually was added as a response to another issue
https://github.com/apache/airflow-client-python/issues/21 where dag triggering
did not work at all :).
So we are facing high likelihood we are going to break workflows of the
people whose problem we solved before and even gave them some examples on how
to do stuff :)
Actually I am quite fine that we say now "you are doing it wrong" - I think
that would be cleanest solution, but likely maybe we should explain it in
release notes how to use DAG RUN triggering now at the very least ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
