mikaeld commented on PR #31043:
URL: https://github.com/apache/airflow/pull/31043#issuecomment-1538395605

   @potiuk I've given another look at this. It seems the 
`airflow_aux/test_pod_template_file.py` unit tests are broken. They test values 
using `show_only=["templates/pod-template-file.yaml"],` but all (except 4) do 
not specify an executor in the test values. 
   
   `chart/files/pod-template-file.kubernetes-helm-yaml` is used in 
`chart/templates/configmaps/configmap.yaml`
   
   ```yaml
   {{- if or (eq $.Values.executor "LocalKubernetesExecutor") (eq 
$.Values.executor "KubernetesExecutor") (eq $.Values.executor 
"CeleryKubernetesExecutor") }}
     {{- if semverCompare ">=1.10.12" .Values.airflowVersion }}
     pod_template_file.yaml: |-
       {{- if .Values.podTemplate }}
         {{- tpl .Values.podTemplate . | nindent 4 }}
       {{- else }}
         {{- tpl (.Files.Get "files/pod-template-file.kubernetes-helm-yaml") . 
| nindent 4 }}
       {{- end }}
     {{- end }}
     {{- end }}
   ```
   
   You need to explicitly set the executor to one the Kubernetes ones, 
otherwise this won't get rendered. Hence, why I believe those test failures are 
unrelated to this PR. If that's the case, I'm wondering why those failures are 
not caught by the test suite. I'll attempt to fix them and report back


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to