dstandish commented on PR #29905:
URL: https://github.com/apache/airflow/pull/29905#issuecomment-1549190593

   > > I am confused what was the basis of this change. I thought AIP-21 just 
said that you should omit the _operator suffix. Why remove the kubernetes_? We 
still keep it (and very much need it), for example, on the kubernetes hook?
   > 
   > Please explain why this is needed? All providers are aligned without the 
prefix this is the convention.
   
   My sentence structure maybe makes it harder to see but to clarify I'm 
talking about with kubernetes hook we call the file `kubernetes.py` -- what 
would you call it if you removed the "kubernetes"?  That's what I mean. :) 
   
   > > I should clarify, specifically I'm concerned with the rename of 
kubernetes_pod.py > pod.py
   > 
   > Please clarify why. We are not going to remove kubernetes_pod.py any time 
soon.. This is one that will stay with us for long till we are fully confident 
that most users migrated. At least 1 year to my taste.. even more (at least 
this is how I see it)
   
   When I wrote "specifically I'm concerned" I was clarifying that that was the 
rename I was asking about because there were other renames in the PR but I was 
just asking about pod.py (initially i said "what's the reason for this change" 
so it wasn't clear what I was asking about.  I'm not saying that the change is 
like... especially "concerning" just clarifying what I'm asking about.
   
   But yeah so anyway, just not sure why the change and curious to understand, 
does not seem that it is required / suggested / indicated by the AIP.  I 
thought that `kubernetes_pod.py` was the right name -- just chopping the 
`_operator` suffix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to