uranusjr commented on code in PR #31301:
URL: https://github.com/apache/airflow/pull/31301#discussion_r1195805114
##########
airflow/www/views.py:
##########
@@ -1877,20 +1877,61 @@ def delete(self):
@provide_session
def trigger(self, session: Session = NEW_SESSION):
"""Triggers DAG Run."""
- dag_id = request.values["dag_id"]
- run_id = request.values.get("run_id", "")
+ dag_id = request.values.get("dag_id")
origin = get_safe_url(request.values.get("origin"))
+ if not dag_id:
+ flash("No dag_id provided for trigger form.", "error")
Review Comment:
```suggestion
flash("No dag_id provided.", "error")
```
This is very unlikely and would suggest something very broken though?
Instead of emitting a flash that the user can’t fix, it may be easier to show a
crash screen instead.
##########
airflow/www/views.py:
##########
@@ -1877,20 +1877,61 @@ def delete(self):
@provide_session
def trigger(self, session: Session = NEW_SESSION):
"""Triggers DAG Run."""
- dag_id = request.values["dag_id"]
- run_id = request.values.get("run_id", "")
+ dag_id = request.values.get("dag_id")
origin = get_safe_url(request.values.get("origin"))
+ if not dag_id:
+ flash("No dag_id provided for trigger form.", "error")
Review Comment:
```suggestion
flash("No dag_id provided.", "error")
```
This is very unlikely and would suggest something very broken though?
Instead of emitting a flash that the user can’t fix, it may be better to show a
crash screen instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]