dzhigimont commented on PR #30742:
URL: https://github.com/apache/airflow/pull/30742#issuecomment-1552105612

   > This looks fine. I’m wondering though, instead of changing the logic to 
count (mapped) task instances, would it be easier to use something like `GROUP 
BY` to count _tasks_? In other words, if a task is mapped, we count 1 when and 
only when all the mapped instances of the task are finished, and 0 otherwise. 
This shouldn’t affect the general behaviour of the sensor, but I think can save 
at least one database query (if my mental model on this is correct).
   
   @uranusjr Hi, I think it's not so easy to write that query, and it can be 
overcomplicated. For me, that overcomplication doesn't cost of saving one not 
heavy query.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to