coufon commented on issue #5594: [AIRFLOW-4924] Loading DAGs asynchronously in Airflow webserver URL: https://github.com/apache/airflow/pull/5594#issuecomment-514820311 Thanks Jarek! Very helpful comments. > 3. Why don't we inject "airflow_class_name = 'ClassName'" field in the stringified BaseOperator while we stringify it and use it as the name displayed in the UI (and everywhere where needed)? I think that might be really simple solution. No problems with loading the external modules (cause there is no need - we only need name from what I understand) I think this solution is better. I will move forward to add this in this PR. > 4. Why don't we load the "real" DAG just to display the templated fields - when they are actually clicked ? That will surely cause delays when displaying the tab, but maybe it's better than error. It should be rather easy - you can create a separate DagBag with just the single Dag as "folder" and from what I know, it should load that DAG (and then you could figure out and load needed modules before you display it). Maybe that's a solution (but also maybe it's not that necessary to fix this particular tab in this - really - edge case. I agree that displaying error should be avoided here. I will first check another solution: whether we can do the template rendering at DAG loading time? So stringified DAG already contains the rendered template. > 5. I believe it's not a problem? Yes. It is not a problem since these fields are rarely displayed and not useful.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
