eladkal commented on code in PR #30698:
URL: https://github.com/apache/airflow/pull/30698#discussion_r1204074285
##########
airflow/providers/snowflake/hooks/sql_api_generate_jwt.py:
##########
@@ -0,0 +1,174 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
This is not a hook.
it looks more like util and should be in util path
##########
airflow/providers/snowflake/provider.yaml:
##########
@@ -74,6 +74,8 @@ hooks:
- integration-name: Snowflake
python-modules:
- airflow.providers.snowflake.hooks.snowflake
+ - airflow.providers.snowflake.hooks.snowflake_sql_api
+ - airflow.providers.snowflake.hooks.sql_api_generate_jwt
Review Comment:
This is not right. it's not a hook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
