potiuk commented on PR #31565: URL: https://github.com/apache/airflow/pull/31565#issuecomment-1564733617
Comment/question: Just checking what was the intention here, because it won't (yet) make it usable for AIP-44. Maybe it's not complete solution yet, but the idea we had was that in some cases when we want to get (say) DagRun class, it will get serialized as DAGRunPydantic (by running fromOrm(dagRun) automatically). so in this case we are not trying to serialize PyDantic object, but we are trying to serialize ORM object as a Pydantic version of it. So in our case in a number of cases we will have: 1. DagRun -> serialize-> DagRunPydantic(serialized) -> deserialize -> DagRunPydantic. and in some other (less important for us) cases: 2. DagRunPydantic -> serialize-> DagRunPydantic(serialized) -> deserialize -> DagRunPydantic. So if I understand correctly with this case we really handle the "deserialize" part in 1. and whole case 2. - we still will need to add the part of serde that properly serializes the DagRun (and few other ORM classes). Is that the right understanding :)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
