hussein-awala commented on code in PR #31625:
URL: https://github.com/apache/airflow/pull/31625#discussion_r1211941808
##########
tests/charts/airflow_core/test_worker.py:
##########
@@ -82,6 +82,18 @@ def test_should_add_extra_containers(self):
"image": "test-registry/test-repo:test-tag",
} == jmespath.search("spec.template.spec.containers[-1]", docs[0])
+ def test_disable_wait_for_migration(self):
+ docs = render_chart(
+ values={
+ "workers": {
+ "waitForMigrations": {"enabled": False},
+ },
+ },
+ show_only=["templates/workers/worker-deployment.yaml"],
+ )
+ actual = jmespath.search("spec.template.spec.initContainers", docs[0])
+ assert actual is None
Review Comment:
If we add a new init container by default to the worker pod, this test will
fail automatically, I wonder if we should assert that the `initContainers`
object is None or it's a list but doesn't contain the
`wait-for-airflow-migrations` container. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]