fkabs opened a new issue, #31668:
URL: https://github.com/apache/airflow/issues/31668

   ### What do you see as an issue?
   
   I found a small bug in the DAG Core Concepts documentation regarding the 
`@daily`schedule:
   
https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/dags.html#running-dags
   
   DAGs do not require a schedule, but it’s very common to define one. You 
define it via the `schedule` argument, like this:
   
   ```python
   with DAG("my_daily_dag", schedule="@daily"):
       ...
   ```
   
   The `schedule` argument takes any value that is a valid 
[Crontab](https://en.wikipedia.org/wiki/Cron) schedule value, so you could also 
do:
   
   ```python
   with DAG("my_daily_dag", schedule="0 * * * *"):
       ...
   ```
   
   If I'm not mistaken, the daily crontab notation should be `0 0 * * *` 
instead of `0 * * * *`, otherwise the DAG would run every hour.
   
   The second `0`of course needs to be replaced with the hour, at which the DAG 
should run daily.
   
   ### Solving the problem
   
   I would change the documentation at the marked location:
   
   The `schedule` argument takes any value that is a valid 
[Crontab](https://en.wikipedia.org/wiki/Cron) schedule value, so for a daily 
run at 00:00, you could also do:
   
   ```python
   with DAG("my_daily_dag", schedule="0 0 * * *"):
       ...
   ```
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to