vincbeck commented on PR #31018: URL: https://github.com/apache/airflow/pull/31018#issuecomment-1572096217
> > > Can you recommend any other ways to test this? We have usually tested the other deferrable operators with unit tests only. > > > > > > It's actually a problem right now that we cannot have deferrable operations in system tests. I intend to start a conversation about this in the mailing list, to decide together how to move forward. > > In the meantime, you can test it in an actual airflow environment (for instance by running `breeze start-airflow`), making sure the _deferration_ happens (by fulfilling the condition after the sensor starts in this case). > > What I was pointing at is that whether deferrable is true or false in the system test here doesn't really change anything. > > @vandonr-amz I have already tested the `S3KeySensor` in deferrable mode using breeze (`breeze start-airflow` and running the DAG). It defers correctly and runs the task sucessfully. > > For deferrable operations in system tests, we can create a separate issue and it can be handled as part of that. +1 on that one. We should not block this PR because of that but we definitely need to discuss about this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
