syedahsn commented on PR #31749: URL: https://github.com/apache/airflow/pull/31749#issuecomment-1581724115
> @syedahsn, you probably missed my comment in the other PR, See [#31018 (comment)](https://github.com/apache/airflow/pull/31018#issuecomment-1567947772). Since duplication is the issue, can you do this when the other PR is merged? The other PR also added some dags which we can run in system tests when deferrable on system tests is supported I saw your comment, but I decided to open this PR to get your thoughts (as well as the community's) on the approach I took for this sensor. As I mentioned in the initial PR for this sensor, one concern is the amount of code that is being duplicated for the async case. I think that keeping code duplication to a minimum is very important because it will lead to a code base that is easier to maintain, and less error-prone. I'm willing to wait for the merge of https://github.com/apache/airflow/pull/31018 before addressing the code duplication, but because of the differences in our approaches, it would mean that I would end up removing a lot of the code introduced in https://github.com/apache/airflow/pull/31018. I'll leave it to you to decide whether we should merge the inital PR and I address the code duplication in a follow-up PR or whether we collaborate now to come up with a suitable solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
