uranusjr commented on code in PR #31735:
URL: https://github.com/apache/airflow/pull/31735#discussion_r1222686551


##########
airflow/kubernetes/pod_launcher_deprecated.py:
##########
@@ -306,15 +306,15 @@ def process_status(self, job_id, status):
         """Process status information for the job."""
         status = status.lower()
         if status == PodStatus.PENDING:
-            return State.QUEUED
+            return TaskInstanceState.QUEUED
         elif status == PodStatus.FAILED:
             self.log.error("Event with job id %s Failed", job_id)
-            return State.FAILED
+            return TaskInstanceState.FAILED
         elif status == PodStatus.SUCCEEDED:
             self.log.info("Event with job id %s Succeeded", job_id)
-            return State.SUCCESS
+            return TaskInstanceState.SUCCESS

Review Comment:
   This could be another instance where we should better introduce a new type, 
I’ll revert this for now as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to