MaliArbov commented on PR #31843: URL: https://github.com/apache/airflow/pull/31843#issuecomment-1586154697
Sure, I'll do it. בתאריך יום א׳, 11 ביוני 2023 ב-12:12 מאת Jarek Potiuk < ***@***.***>: > Good idea. But could you please add a unit test for the operator (similar > that we have for the regular branch one - you can see how external Python > operator unit tests are done and you can do in a similar). > > The reason why we need tests is that when we cherry-pick such changes or > make future changes, those tests help to keep our code to be free from > regressions, there are cases and refactoring that *might* break things > and such unit tests prevent it. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/airflow/pull/31843#issuecomment-1586085368>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/A7L5GHCS5J3OODCD36KEG3DXKWDWXANCNFSM6AAAAAAZCGASRU> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
