uranusjr commented on code in PR #31852: URL: https://github.com/apache/airflow/pull/31852#discussion_r1228385706
########## airflow/models/taskinstance.py: ########## @@ -886,6 +889,7 @@ def refresh_from_task(self, task: Operator, pool_override: str | None = None) -> # value that needs to be stored in the db. self.executor_config = task.executor_config self.operator = task.task_type + self.custom_operator_name = task.operator_name Review Comment: In the current approach, _old_ rows in `task_instance` (that existed before the migration) would have NULL and you still need to handle those anyway. So it’s a bit inconsistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org