uranusjr commented on code in PR #31960: URL: https://github.com/apache/airflow/pull/31960#discussion_r1233632049
########## airflow/providers/amazon/aws/operators/eks.py: ########## @@ -59,7 +59,55 @@ FARGATE_FULL_NAME = "AWS Fargate profiles" -class EksCreateClusterOperator(BaseOperator): +class BaseEksCreateOperator(BaseOperator): + """ + Base class for EKS Operators that create cluster resources. This includes + EksCreateClusterOperator, EksCreateNodeGroupOperator and EksCreateFargateProfileOperator. + + """ + + def __init__(self, **kwargs): + self.eks_hook = EksHook(aws_conn_id=self.aws_conn_id, region_name=self.region) + super().__init__(**kwargs) Review Comment: Any reason the hook is instantiated before the `super()` call? I believe the majority preference is to do it after the super call. (I don’t think the style matters here, but it may introduce unnecessary confusion.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
