jedcunningham commented on code in PR #31066:
URL: https://github.com/apache/airflow/pull/31066#discussion_r1237846331


##########
chart/templates/secrets/fernetkey-secret.yaml:
##########
@@ -35,7 +35,7 @@ metadata:
       {{- toYaml . | nindent 4 }}
     {{- end }}
   annotations:
-    "helm.sh/hook": "pre-install"
+    "helm.sh/hook": "pre-install,pre-upgrade"

Review Comment:
   I don't have a good suggestion unfortunately. We've considered 
[lookup](https://helm.sh/docs/chart_template_guide/function_list/#lookup) but 
never used it because of the it's behavior with template (which things like 
helm-diff and argocd use). Welcome to the backcompat nightmare :(
   
   It might be worth leaving comments so when we do get around to accepting 
breaking changes in preparation for major version 2 of the chart, we can 
address it then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to