o-nikolas commented on PR #32101: URL: https://github.com/apache/airflow/pull/32101#issuecomment-1608463301
Also this backfill code has changed since I last touched it for AIP-51. I'm confused why we're checking executor compatibility for the executor class on self.job (`self.job.executor`) instead of the executor that's passed into this method (`executor`) used on the line below (invalidating the above check for local anyway?): https://github.com/apache/airflow/blob/45bd9c993ee87789e01aae55f8abb34a0ff1de48/airflow/jobs/backfill_job_runner.py#L543-L549 @potiuk It looks like you made that change in #30255, do you have any context on that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
