potiuk commented on PR #32175: URL: https://github.com/apache/airflow/pull/32175#issuecomment-1609979829
> I have a custom k8s mutating webhook that integrates with Hashicorp vault. It needs to read the command of a container to apply the mutation. I am not sure if I follow what mutation and what command reading is needed? Could you please explain a bit more? I have a f That sounds like a very specific use case that is probably better to handle by making your deployment adapt (not sure? Annotations assigned to the image for example seems like standard way to be able to distinguish between different containers/pods). Using "entrypoint" for that sounds very weird so I would like to know more. Can you please explai what is exactly you need it for? Generally the more variables and configuiration in the options - the more complex things are - for example - if you look now at your PR for example - tests are failing after your change. In order to get it mergable, you would not not only need to fix them but add a new set of unit tests that should cover regressions and add test cases for different git-sync command. And likely we need a documentation update describing when and how you would llike to use it (likely ih production guide - explaining what is the use case and why you would like to use it - so basically my question above will help you understand what kind of documentation you willl need to write). So I am not saying it's wrong, I am saying it's quite a lot of work (for you mainly) to make it mergable, and I wonder if your use case is strong enough so that you are willing to commit to completing it and whether it is important enough to justify the added complexity. BTW. I am not sure if we want to add anything for more configurable image, if we allow that, this is even more complexity and tests needed, and we can easily have a requirement that any replacement for git-sync image must have "/git-sync" entrypoint, so that variablity is really unnecessary complication, if your case can be handled differently -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
