bolkedebruin commented on PR #31866:
URL: https://github.com/apache/airflow/pull/31866#issuecomment-1612788272
`_convert` was created to handle old (pre 2.6) XCom seralized data, but the
issue is that the new deserializer cannot handle:
```
{'extra': {'__type': 'dict', '__var': {'hi': 'bye'}}, 'uri':
's3://does_not_exist'}
```
Which is the nested form of the old style serialization.
I think the solution is correct, but that the commit message and the inline
comments could be improved. As mentioned this code was already handling pre 2.6
data, but it wasn't handling the nested version of that correctly. Also I think
the test could use some improvement / addition. The above `dict` should be able
to be deseralized directly. So I would expect an additional test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
