ephraimbuddy commented on code in PR #32177:
URL: https://github.com/apache/airflow/pull/32177#discussion_r1250436298
##########
airflow/utils/db.py:
##########
@@ -1101,7 +1102,7 @@ def check_conn_type_null(session: Session) ->
Iterable[str]:
n_nulls = []
try:
- n_nulls =
session.query(Connection.conn_id).filter(Connection.conn_type.is_(None)).all()
+ n_nulls =
session.execute(select(Connection.conn_id).filter(Connection.conn_type.is_(None))).all()
Review Comment:
```suggestion
n_nulls =
session.scalar(select(Connection.conn_id).filter(Connection.conn_type.is_(None)))
```
I feel like `scalar` would be better here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
