ephraimbuddy commented on code in PR #32313:
URL: https://github.com/apache/airflow/pull/32313#discussion_r1251526258
##########
airflow/jobs/local_task_job_runner.py:
##########
@@ -158,7 +158,7 @@ def sigusr2_debug_handler(signum, frame):
try:
self.task_runner.start()
- heartbeat_time_limit = conf.getint("scheduler",
"scheduler_zombie_task_threshold")
+ heartbeat_time_limit = conf.getint("scheduler",
"local_task_job_heartbeat_sec")
Review Comment:
I wonder why a different heartbeat was used here instead of the jobs
heartrate. Do we really need this configuration or we should use
JOB_HEARTBEAT_SEC? It's already set for this localtaskjob, If there's no
apparent reason for a different configuration, I think we should use
self.job.heartrate for this without any other configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
