amoghrajesh commented on code in PR #31663:
URL: https://github.com/apache/airflow/pull/31663#discussion_r1252030400
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -342,6 +348,9 @@ def __init__(
self.cluster_context = cluster_context
self.reattach_on_restart = reattach_on_restart
self.get_logs = get_logs
+ self.container_logs = container_logs
+ if base_container_name and self.container_logs ==
KubernetesPodOperator.BASE_CONTAINER_NAME:
Review Comment:
Yes that should work and it should be the fallback condition.
@hussein-awala's point makes sense to me now. We do not need the nil check
for `base_container_name`. Changing this part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
