Joffreybvn commented on code in PR #32319:
URL: https://github.com/apache/airflow/pull/32319#discussion_r1252223599
##########
airflow/providers/odbc/hooks/odbc.py:
##########
@@ -211,3 +215,9 @@ def get_sqlalchemy_connection(
engine = self.get_sqlalchemy_engine(engine_kwargs=engine_kwargs)
cnx = engine.connect(**(connect_kwargs or {}))
return cnx
+
+ def _make_serializable(self, result: list[pyodbc.Row]) -> list[tuple] |
list[pyodbc.Row]:
Review Comment:
No, when the result is made serializable, Row objects are transformed into
pure Python data structure (tuples). Thus, in this case, it should either
return a list of tuple, or return directly the given data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
