uranusjr commented on code in PR #32122:
URL: https://github.com/apache/airflow/pull/32122#discussion_r1255388320
##########
airflow/decorators/task_group.py:
##########
@@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) ->
_TaskGroupFactory[FParams, FReturn]:
# TODO: fixme when mypy gets compatible with new attrs
return attr.evolve(self, partial_kwargs=kwargs) # type:
ignore[arg-type]
- def expand(self, **kwargs: OperatorExpandArgument) -> DAGNode:
+ def expand(self, concurrency_limit: int = None, **kwargs:
OperatorExpandArgument) -> DAGNode:
Review Comment:
Maybe `groups`? It’s pretty obviously task groups, after all?
##########
airflow/decorators/task_group.py:
##########
@@ -124,14 +124,14 @@ def partial(self, **kwargs: Any) ->
_TaskGroupFactory[FParams, FReturn]:
# TODO: fixme when mypy gets compatible with new attrs
return attr.evolve(self, partial_kwargs=kwargs) # type:
ignore[arg-type]
- def expand(self, **kwargs: OperatorExpandArgument) -> DAGNode:
+ def expand(self, concurrency_limit: int = None, **kwargs:
OperatorExpandArgument) -> DAGNode:
Review Comment:
Maybe `groups`? It’s pretty obviously task groups, after all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
