[ 
https://issues.apache.org/jira/browse/AIRFLOW-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896688#comment-16896688
 ] 

ASF GitHub Bot commented on AIRFLOW-2891:
-----------------------------------------

rocketbitz commented on pull request #5689: [AIRFLOW-2891] Option to set 
container_name for DockerOperator
URL: https://github.com/apache/airflow/pull/5689
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following:
     - https://issues.apache.org/jira/browse/AIRFLOW-2891
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
     - allows specification of docker container name for containers spawned by 
DockerOperators
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
     - I have added to existing tests
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Option to set container_name for DockerOperator
> -----------------------------------------------
>
>                 Key: AIRFLOW-2891
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2891
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: operators
>            Reporter: Wouter Menninga
>            Priority: Minor
>              Labels: docker
>
> It would be nice if the name of a Docker container created using the 
> {{DockerOperator}} could be specified by passing it as an argument to 
> {{DockerOperator}}, instead of having Docker generate its random name for the 
> container.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to