potiuk commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1261542429
##########
scripts/in_container/verify_providers.py:
##########
@@ -714,12 +714,17 @@ def run_provider_discovery():
subprocess.run(["airflow", "providers", "secrets"], check=True)
console.print("[bright_blue]List all auth backends[/]\n")
subprocess.run(["airflow", "providers", "auth"], check=True)
- if packaging.version.parse(airflow.version.version) >=
packaging.version.parse("2.7.0.dev0"):
+ if packaging.version.parse(airflow.version.version) >=
packaging.version.parse("2.6.0.dev0"):
# CI also check if our providers are installable and discoverable in
airflow older versions
# But the triggers command is not available till airflow-2-6-0
# TODO: Remove this block once airflow dependency in providers are >
2-6-0
console.print("[bright_blue]List all triggers[/]\n")
subprocess.run(["airflow", "providers", "triggers"], check=True)
+ if packaging.version.parse(airflow.version.version) >=
packaging.version.parse("2.7.0.dev0"):
+ # CI also check if our providers are installable and discoverable in
airflow older versions
+ # But the triggers command is not available till airflow-2-7-0
Review Comment:
```suggestion
# But the executors command is not available till airflow-2-7-0
```
##########
scripts/in_container/verify_providers.py:
##########
@@ -714,12 +714,17 @@ def run_provider_discovery():
subprocess.run(["airflow", "providers", "secrets"], check=True)
console.print("[bright_blue]List all auth backends[/]\n")
subprocess.run(["airflow", "providers", "auth"], check=True)
- if packaging.version.parse(airflow.version.version) >=
packaging.version.parse("2.7.0.dev0"):
+ if packaging.version.parse(airflow.version.version) >=
packaging.version.parse("2.6.0.dev0"):
# CI also check if our providers are installable and discoverable in
airflow older versions
# But the triggers command is not available till airflow-2-6-0
# TODO: Remove this block once airflow dependency in providers are >
2-6-0
console.print("[bright_blue]List all triggers[/]\n")
subprocess.run(["airflow", "providers", "triggers"], check=True)
+ if packaging.version.parse(airflow.version.version) >=
packaging.version.parse("2.7.0.dev0"):
+ # CI also check if our providers are installable and discoverable in
airflow older versions
+ # But the triggers command is not available till airflow-2-7-0
Review Comment:
of course :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
