uranusjr commented on code in PR #32313: URL: https://github.com/apache/airflow/pull/32313#discussion_r1262015655
########## airflow/config_templates/default_airflow.cfg: ########## @@ -1195,6 +1195,11 @@ job_heartbeat_sec = 5 # how often the scheduler should run (in seconds). scheduler_heartbeat_sec = 5 +# The frequency (in seconds) at which the LocalTaskJob should send heartbeat signals to the +# scheduler to notify it's still alive. If this value is set to 0, the heartbeat interval will default +# to scheduler's `scheduler_zombie_task_threshold` config. +local_task_job_heartbeat_sec = 0 Review Comment: Is it reasonable to _want_ the heartbeat interval to be actually zero (i.e. as soon as possible)? I’m wondering if -1 ia better default. ```suggestion # The frequency (in seconds) at which the LocalTaskJob should send heartbeat signals to the # scheduler to notify it's still alive. If this value is set to 0, the heartbeat interval will default # to the value of scheduler_zombie_task_threshold. local_task_job_heartbeat_sec = 0 ``` ########## airflow/config_templates/default_airflow.cfg: ########## @@ -1195,6 +1195,11 @@ job_heartbeat_sec = 5 # how often the scheduler should run (in seconds). scheduler_heartbeat_sec = 5 +# The frequency (in seconds) at which the LocalTaskJob should send heartbeat signals to the +# scheduler to notify it's still alive. If this value is set to 0, the heartbeat interval will default +# to scheduler's `scheduler_zombie_task_threshold` config. +local_task_job_heartbeat_sec = 0 Review Comment: Is it reasonable to _want_ the heartbeat interval to be actually zero (i.e. as soon as possible)? I’m wondering if -1 ia better default. ```suggestion # The frequency (in seconds) at which the LocalTaskJob should send heartbeat signals to the # scheduler to notify it's still alive. If this value is set to 0, the heartbeat interval will default # to the value of scheduler_zombie_task_threshold. local_task_job_heartbeat_sec = 0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
