vincbeck commented on code in PR #32525: URL: https://github.com/apache/airflow/pull/32525#discussion_r1262922283
########## airflow/www/fab_security/manager.py: ########## @@ -208,12 +206,6 @@ def oauth_tokengetter(token=None): userstatschartview = UserStatsChartView permissionmodelview = PermissionModelView - @cached_property - def resourcemodelview(self): Review Comment: Good question. The main goal is to, iteratively, move everything related to FAB from the different security managers (`airflow/www/fab_security/manager.BaseSecurityManager`, `airflow/www/fab_security/sqla/manager.SecurityManager`, `airflow/www/security.py.AirflowSecurityManager`) to the `FabAirflowSecurityManagerOverride`. Ideally, auth managers do not have to override the security manager, only if they want/need. The end goal is that everything we move from the security managers to `FabAirflowSecurityManagerOverride` are not needed if you dont use the FAB auth manager. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org