mahammi commented on PR #32498:
URL: https://github.com/apache/airflow/pull/32498#issuecomment-1634716859

   > > The failing test has a suggestion to add the operator to a "no example 
available" list 
[here](https://github.com/apache/airflow/blob/main/tests/always/test_project_structure.py#L284),
 I think that makes more sense than a non-functional dag for now.
   > 
   > I'd be worried about setting a precedent doing this. People will start 
ignoring them and forgetting about it.
   > 
   > What's the concern with writing a functioning system test? It's a pretty 
well dialed process nowadays.
   
   
   
   > > The failing test has a suggestion to add the operator to a "no example 
available" list 
[here](https://github.com/apache/airflow/blob/main/tests/always/test_project_structure.py#L284),
 I think that makes more sense than a non-functional dag for now.
   > 
   > I'd be worried about setting a precedent doing this. People will start 
ignoring them and forgetting about it.
   > 
   > What's the concern with writing a functioning system test? It's a pretty 
well dialed process nowadays.
   
   The main concern that I discussed with Dennis is just the fact that there 
isn't a way to see whether events have been sent to EventBridge. All events are 
either sent to the targets via rules, or dropped if there are no targets 
immediately after receiving the events, meaning we would need the PutRule 
operator before we can do much with this one (in a DAG at least). I can make an 
example DAG, but I don't know how useful that would be at the moment. Once more 
operators are made, we can always edit the example DAG, though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to