vandonr-amz commented on code in PR #32589:
URL: https://github.com/apache/airflow/pull/32589#discussion_r1264020600
##########
airflow/providers/amazon/aws/triggers/ecs.py:
##########
@@ -179,8 +181,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
finally:
if self.log_group and self.log_stream:
logs_token = await self._forward_logs(logs_client,
logs_token)
-
- yield TriggerEvent({"status": "success", "task_arn": self.task_arn})
+ raise AirflowException("Waiter error: max attempts reached")
Review Comment:
I disagree, yielding an event will send this back to the scheduler, and
require a worker to be setup and everything just to throw an error there. Might
as well save all this by raising directly in the triggerer.
I was discussed quickly in this slack thread:
https://apache-airflow.slack.com/archives/CCPRP7943/p1685663968275419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
