vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1264140862
########## airflow/utils/context.pyi: ########## @@ -37,11 +37,13 @@ from airflow.models.dagrun import DagRun from airflow.models.dataset import DatasetEvent from airflow.models.param import ParamsDict from airflow.models.taskinstance import TaskInstance -from airflow.serialization.pydantic.dag_run import DagRunPydantic -from airflow.serialization.pydantic.dataset import DatasetEventPydantic -from airflow.serialization.pydantic.taskinstance import TaskInstancePydantic from airflow.typing_compat import TypedDict +if TYPE_CHECKING: + from airflow.serialization.pydantic.dag_run import DagRunPydantic + from airflow.serialization.pydantic.dataset import DatasetEventPydantic + from airflow.serialization.pydantic.taskinstance import TaskInstancePydantic Review Comment: Nice! ########## airflow/ti_deps/deps/prev_dagrun_dep.py: ########## @@ -19,6 +19,7 @@ from sqlalchemy import func +from airflow.models import DagRun Review Comment: Good catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
