potiuk commented on PR #32605:
URL: https://github.com/apache/airflow/pull/32605#issuecomment-1637394157

   > > I had checked the current unit test and all are convenient for that 
change.
   > 
   > How so? In the ticket you mentioned a bug report. If after a code change 
tests still pass without change it means that there is no coverage for this and 
the code can break again with future development. To avoid it you need to add 
new tests/modify current tests to make sure the bug that you fixed now won't 
happen again.
   
   A comment: I spole to @frodo2000 off-line and he told me he is on holidays 
now but will fix it after he is back (I explained it in the very same terms you 
did @eladkal).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to