vandonr-amz commented on code in PR #32437: URL: https://github.com/apache/airflow/pull/32437#discussion_r1265719265
########## airflow/providers/amazon/aws/triggers/rds.py: ########## @@ -18,11 +18,17 @@ from typing import Any +from deprecated import deprecated + +from airflow.providers.amazon.aws.hooks.base_aws import AwsGenericHook from airflow.providers.amazon.aws.hooks.rds import RdsHook +from airflow.providers.amazon.aws.triggers.base import AwsBaseWaiterTrigger +from airflow.providers.amazon.aws.utils.rds import RdsDbType from airflow.providers.amazon.aws.utils.waiter_with_logging import async_wait from airflow.triggers.base import BaseTrigger, TriggerEvent +@deprecated(reason="Use the other specialized RDS triggers") Review Comment: ah there was a comment recently by @eladkal that we shouldn't use those deprecated annotations in providers, so I'll change it. But my honest opinion (backed by absolutely no data) on this is that there is no user dealing with this trigger directly, so writing a detailed guide would be a waste of time (and also, they are here in the same file, it's not too complex to sort it out if you are the kind of user to write your own triggers by deriving this one) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
