uranusjr commented on issue #27399:
URL: https://github.com/apache/airflow/issues/27399#issuecomment-1640983709
```python
elif last_automated_data_interval.end == self._align_to_prev(current_time):
# The last run is the same as the previously scheduled run. Everything
is working fine.
next_start_time = self._align_to_next(current_time)
```
This part has a bug when `current_time` is _exactly_
`last_automated_data_interval.end`, `next_start_time` would be set to
`current_time` again (because the align functions will try to not move the time
if it already lands on the cron). Very unlikely but still. I think it can be
avoided with `self._get_next(last_automated_data_interval.end)` instead, to
ensure the logic progresses one interval ahead.
The `else` block is essentially the same as the change discused above and
looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
