ivica-k commented on code in PR #32785:
URL: https://github.com/apache/airflow/pull/32785#discussion_r1272371737
##########
tests/providers/amazon/aws/hooks/test_redshift_data.py:
##########
@@ -39,22 +41,53 @@ def test_conn_attribute(self):
@mock.patch("airflow.providers.amazon.aws.hooks.redshift_data.RedshiftDataHook.conn")
def test_execute_without_waiting(self, mock_conn):
mock_conn.execute_statement.return_value = {"Id": STATEMENT_ID}
+ cluster_identifier = "cluster_identifier"
hook = RedshiftDataHook()
hook.execute_query(
database=DATABASE,
+ cluster_identifier=cluster_identifier,
sql=SQL,
wait_for_completion=False,
)
mock_conn.execute_statement.assert_called_once_with(
Database=DATABASE,
+ ClusterIdentifier=cluster_identifier,
Sql=SQL,
WithEvent=False,
)
mock_conn.describe_statement.assert_not_called()
@mock.patch("airflow.providers.amazon.aws.hooks.redshift_data.RedshiftDataHook.conn")
- def test_execute_with_all_parameters(self, mock_conn):
+ def test_execute_requires_cluster_identifier_or_workgroup_name(self,
mock_conn):
+ mock_conn.execute_statement.return_value = {"Id": STATEMENT_ID}
+
+ with pytest.raises(ValueError):
+ hook = RedshiftDataHook()
+ hook.execute_query(
+ database=DATABASE,
+ sql=SQL,
+ wait_for_completion=False,
+ )
+
+
@mock.patch("airflow.providers.amazon.aws.hooks.redshift_data.RedshiftDataHook.conn")
+ def
test_execute_requires_cluster_identifier_or_workgroup_name_not_both(self,
mock_conn):
+ mock_conn.execute_statement.return_value = {"Id": STATEMENT_ID}
+ cluster_identifier = "cluster_identifier"
+ workgroup_name = "workgroup_name"
+
+ with pytest.raises(ValueError):
+ hook = RedshiftDataHook()
+ hook.execute_query(
+ database=DATABASE,
+ cluster_identifier=cluster_identifier,
+ workgroup_name=workgroup_name,
+ sql=SQL,
+ wait_for_completion=False,
+ )
Review Comment:
Good point, improved in 56cc6d8ea13031ca610250735c8b0071065b233f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
