uranusjr commented on code in PR #32820:
URL: https://github.com/apache/airflow/pull/32820#discussion_r1274536835
##########
airflow/models/mappedoperator.py:
##########
@@ -408,8 +390,23 @@ def trigger_rule(self) -> TriggerRule:
@trigger_rule.setter
def trigger_rule(self, value):
- # required for mypy which complains about overriding writeable attr
with read-only property
- raise ValueError("Cannot set trigger_rule for mapped operator.")
+ self.partial_kwargs["trigger_rule"] = value
+
+ @property
+ def is_setup(self):
+ return self.partial_kwargs.get("is_setup", False)
+
+ @is_setup.setter
+ def is_setup(self, value):
+ self.partial_kwargs["is_setup"] = value
Review Comment:
I feel these setters aren’t really needed… There should be a way to supply
those when a MappedOperator is created.
##########
airflow/models/mappedoperator.py:
##########
@@ -408,8 +390,23 @@ def trigger_rule(self) -> TriggerRule:
@trigger_rule.setter
def trigger_rule(self, value):
- # required for mypy which complains about overriding writeable attr
with read-only property
- raise ValueError("Cannot set trigger_rule for mapped operator.")
+ self.partial_kwargs["trigger_rule"] = value
+
+ @property
+ def is_setup(self):
+ return self.partial_kwargs.get("is_setup", False)
+
+ @is_setup.setter
+ def is_setup(self, value):
+ self.partial_kwargs["is_setup"] = value
Review Comment:
I feel these setters aren’t really needed… There should be a way to supply
those when a MappedOperator is created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
