jens-scheffler-bosch commented on code in PR #32858:
URL: https://github.com/apache/airflow/pull/32858#discussion_r1275383631
##########
airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -99,6 +100,12 @@ def get_connection_form_widgets() -> dict[str, Any]:
"cluster_context": StringField(lazy_gettext("Cluster context"),
widget=BS3TextFieldWidget()),
"disable_verify_ssl": BooleanField(lazy_gettext("Disable SSL")),
"disable_tcp_keepalive": BooleanField(lazy_gettext("Disable TCP
keepalive")),
+ "xcom_sidecar_container_image": StringField(
+ lazy_gettext("XCom sidecar image"), widget=BS3TextFieldWidget()
+ ),
+ "xcom_sidecar_container_resources": StringField(
+ lazy_gettext("XCom sidecar resources (JSON format)"),
widget=BS3TextFieldWidget()
+ ),
Review Comment:
I assume to have it working per default, you need to take current hard-coded
values as default here? For all who are not setting up explicitly. So that
"alpine" is sourced. (Or is the default populated from somewhere else?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
