amoghrajesh commented on code in PR #32885:
URL: https://github.com/apache/airflow/pull/32885#discussion_r1276297255
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -238,6 +238,7 @@ class KubernetesPodOperator(BaseOperator):
state, or the execution is interrupted. If True (default), delete the
pod; if False, leave the pod.
Deprecated - use `on_finish_action` instead.
+ :param termination_message_policy: set container
termination_message_policy. Defaults to "File"
Review Comment:
nit: `sets container termination message policy. Default value is "File"`
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -238,6 +238,7 @@ class KubernetesPodOperator(BaseOperator):
state, or the execution is interrupted. If True (default), delete the
pod; if False, leave the pod.
Deprecated - use `on_finish_action` instead.
+ :param termination_message_policy: set container
termination_message_policy. Defaults to "File"
Review Comment:
Can you cover this behaviour using a unit test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
