jens-scheffler-bosch commented on issue #33036: URL: https://github.com/apache/airflow/issues/33036#issuecomment-1662981079
Your proposal sounds reasonable and a good idea. Based on the standard Jinja-based templating I see no other (simple) option to pass a dict (dynamically) into the DockerOperator - at least I don't have a counter proposal immeditately. Nevertheless I am not sure whether the property name is the best as well as it would be advised if _all_ `param`s should be passed into the ENV - and there could be also `params` being defined which are not of type string. So as simple as the approach smells there might be some side effects. Before contributing this to the core - if you need that feature for your purposes - I'd propose to start on your side by implementing a first custom operator by inheriting from the `DockerOperator` and use it for a while. If you gained some experience (might be good to use it for a moment to see how "generic" it is, back-porting and contributing later. Or are you using exactly such kind of operator already and you think about back-porting? (I note this because we do it the same - we use custom operators for a while and after gaining some experience of usage we think about what pieces are really common use and which ones are specific for our environment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
