pankajkoti commented on code in PR #33065:
URL: https://github.com/apache/airflow/pull/33065#discussion_r1283048137
##########
airflow/utils/log/secrets_masker.py:
##########
@@ -143,6 +144,10 @@ def _is_v1_env_var(v: Any) -> TypeGuard[V1EnvVar]:
return isinstance(v, _get_v1_env_var_type())
+def _is_state_enum(v: Any) -> bool:
+ return isinstance(v, (TaskInstanceState, DagRunState, JobState, State))
Review Comment:
Would like to understand if the secrets masker fails for all kinds of Enum
values and if yes, would it be safe to have here,
isinstance(item, Enum)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
