amoghrajesh commented on code in PR #33092:
URL: https://github.com/apache/airflow/pull/33092#discussion_r1284051099
##########
tests/providers/cncf/kubernetes/operators/test_pod.py:
##########
@@ -1232,6 +1232,46 @@ def test_task_skip_when_pod_exit_with_certain_code(
with pytest.raises(expected_exc):
self.run_pod(k)
+ @patch(f"{POD_MANAGER_CLASS}.extract_xcom")
+ @patch(f"{POD_MANAGER_CLASS}.await_xcom_sidecar_container_start")
+ @patch(f"{POD_MANAGER_CLASS}.await_container_completion")
+ @patch(f"{POD_MANAGER_CLASS}.fetch_requested_container_logs")
+ @patch(HOOK_CLASS)
+ def test_get_logs_but_not_for_base_container(
+ self,
+ hook_mock,
+ mock_fetch_log,
+ mock_await_container_completion,
+ mock_await_xcom_sidecar,
+ mock_extract_xcom,
+ ):
+ k = KubernetesPodOperator(
+ namespace="default",
+ image="ubuntu:16.04",
+ cmds=["bash", "-cx"],
+ arguments=["echo 10"],
+ labels={"foo": "bar"},
+ name="test",
+ task_id="task",
+ do_xcom_push=True,
+ container_logs=["some_init_container"],
+ get_logs=True,
+ )
+ mock_extract_xcom.return_value = "{}"
+ remote_pod_mock = MagicMock()
+ remote_pod_mock.status.phase = "Succeeded"
+ self.await_pod_mock.return_value = remote_pod_mock
+ pod = self.run_pod(k)
+
+ # check that the base container is not included in the logs
+ mock_fetch_log.assert_called_once_with(
+ pod=pod, container_logs=["some_init_container"], follow_logs=True
+ )
+ # check that KPO waits for the base container to complete before
proceeding to extract XCom
+ mock_await_container_completion.assert_called_once_with(pod=pod,
container_name="base")
+ # check that we wait for the xcom sidecar to start before extracting
XCom
+ mock_await_xcom_sidecar.assert_called_once_with(pod=pod)
+
Review Comment:
Awesome work on the test cases!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
