pierrejeambrun commented on code in PR #33351:
URL: https://github.com/apache/airflow/pull/33351#discussion_r1292420057


##########
airflow/www/views.py:
##########
@@ -2031,6 +2031,7 @@ def trigger(self, dag_id: str, session: Session = 
NEW_SESSION):
                     form_fields[k]["schema"]["custom_html_form"]
                 )
         ui_fields_defined = any("const" not in f["schema"] for f in 
form_fields.values())
+        show_form_if_no_params = conf.getboolean("webserver", 
"show_trigger_form_if_no_params")

Review Comment:
   ```suggestion
           show_trigger_form_if_no_params = conf.getboolean("webserver", 
"show_trigger_form_if_no_params")
   ```



##########
airflow/www/views.py:
##########
@@ -2057,7 +2058,7 @@ def trigger(self, dag_id: str, session: Session = 
NEW_SESSION):
             if isinstance(run_conf, dict) and any(run_conf)
         }
 
-        if request.method == "GET" and ui_fields_defined:
+        if request.method == "GET" and (ui_fields_defined or 
show_form_if_no_params):

Review Comment:
   ```suggestion
           if request.method == "GET" and (ui_fields_defined or 
show_trigger_form_if_no_params):
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to