dstandish commented on code in PR #33570:
URL: https://github.com/apache/airflow/pull/33570#discussion_r1304619901
##########
airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -234,14 +250,19 @@ def _iter_upstream_conditions() ->
Iterator[ColumnOperators]:
.group_by(TaskInstance.task_id)
).all()
upstream = sum(count for _, count in task_id_counts)
- upstream_setup = sum(c for t, c in task_id_counts if
upstream_tasks[t].is_setup)
upstream_done = done >= upstream
+ setup_done = (success_setup + skipped_setup + failed_setup) >=
upstream_setup
+ is_tear_down = task.is_teardown or trigger_rule ==
TR.ALL_DONE_SETUP_SUCCESS
changed = False
new_state = None
if dep_context.flag_upstream_failed:
- if trigger_rule == TR.ALL_SUCCESS:
+ if not is_tear_down and failed_setup:
Review Comment:
```suggestion
if not is_teardown and failed_setup:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
