eladkal commented on PR #33680:
URL: https://github.com/apache/airflow/pull/33680#issuecomment-1692379256

   > Interesting approach - in this approach I was trying to stay aligned with 
the existing Secret class and usage patterns, whereas this would create a 
largely different (albeit more flexible) avenue for defining and mounting 
secrets. Do you have any especially strong preferences or objections to the 
proposed implementation?
   
   My motivation was that it is far more likely that when you want to inject a 
connection to K8s pod it would be one **already defined in Airflow 
connections** and being used by other operators rather than one stored 
elsewhere and you want to just bake it into the task. Also if that was not the 
case all you need is just to define a new connection. Basicly anything Airflow 
knows will also be accesable from K8s pod.
   
   I think it's also easier to explain to users - just tell us what is the 
conn_id you want and we will make sure it's available in the pod. When 
referencing it just decode the attributes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to