mjsqu commented on code in PR #33712:
URL: https://github.com/apache/airflow/pull/33712#discussion_r1305505482
##########
airflow/providers/amazon/aws/operators/ecs.py:
##########
@@ -476,7 +476,7 @@ def __init__(
number_logs_exception: int = 10,
wait_for_completion: bool = True,
waiter_delay: int = 6,
- waiter_max_attempts: int = 100,
+ waiter_max_attempts: int = sys.maxsize, # Unless specified timeout is
managed by airflow
Review Comment:
Thanks for the review. I agree that adding `sys.maxsize` must have been a
workaround and is a bit non-standard so perhaps this PR might be able to
resolve that by using None.
I had considered if the `max_attempts` and `delay` parameters could be
calculated at runtime by taking into consideration the `execution_timeout`
value, however this would require a bit more of a rewrite of the Operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
